Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update web-sys & wasm-bindgen #4980

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Update web-sys & wasm-bindgen #4980

merged 1 commit into from
Aug 26, 2024

Conversation

bircni
Copy link
Contributor

@bircni bircni commented Aug 18, 2024

This PR updates web-sys & wasm to the newest version.

(this was already part of the POC #4954 )

@bircni bircni marked this pull request as ready for review August 18, 2024 11:00
@bircni bircni mentioned this pull request Aug 25, 2024
Closed
@emilk emilk changed the title update web-sys & wasm Update web-sys & wasm-bindgen Aug 26, 2024
emilk
emilk approved these changes Aug 26, 2024
View reviewed changes
Copy link
Owner

@emilk emilk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Since the pasteboard APIs are now stable, we can remove all references to web_sys_unstable_apis. That is: users do not need to add RUSTFLAGS='--cfg=web_sys_unstable_apis' when using eframe. I'll do that in a follow-up PR.

@emilk emilk added web Related to running Egui on the web eframe Relates to epi and eframe labels Aug 26, 2024
@emilk emilk merged commit 560b298 into emilk:master Aug 26, 2024
20 of 21 checks passed
emilk added a commit that referenced this pull request Aug 26, 2024
@emilk
Remove the need for setting web_sys_unstable_apis
5cfda23 
No longer required since #4980

And despite some outdated comments, wgpu/WebGPU doesn't need it either
@emilk emilk mentioned this pull request Aug 26, 2024
Merged
emilk added a commit that referenced this pull request Aug 26, 2024
@emilk
Remove the need for setting web_sys_unstable_apis
2f0d430 
No longer required since #4980

And despite some outdated comments, wgpu/WebGPU doesn't need it either
emilk added a commit that referenced this pull request Aug 26, 2024
@emilk
Remove the need for setting web_sys_unstable_apis (#5000)
a9a6e0c 
* No longer required since #4980

And despite some outdated comments, wgpu/WebGPU doesn't need it either
@BGR360 BGR360 mentioned this pull request Sep 2, 2024
Closed
@BGR360
Copy link

BGR360 commented Sep 5, 2024

When will we see this released as a new patch version?

@emilk
Copy link
Owner

emilk commented Sep 6, 2024

I'm aiming to do a major release (0.29) in the next week or two

@bircni bircni mentioned this pull request Sep 9, 2024
Closed
@bircni bircni deleted the patch05 branch September 9, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
eframe Relates to epi and eframe web Related to running Egui on the web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unstable clipboard logic on web is incompatible with web_sys 0.3.70 web-sys 0.70 issue
3 participants
@bircni @BGR360 @emilk