Fix: Speed issues on Windows when immediate viewport is on another screen #5250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/5250-patch136 |
emilk
reviewed
Oct 23, 2024
Comment on lines
-705
to
-708
| // Prune dead viewports: | ||
| viewports.retain(|id, _| active_viewports_ids.contains(id)); | ||
| viewport_from_window.retain(|_, id| active_viewports_ids.contains(id)); | ||
| painter.gc_viewports(&active_viewports_ids); |
There was a problem hiding this comment.
What happened with this code?
It is not necessary as it is handled in handle_viewport_output().
| @@ -954,8 +949,6 @@ fn render_immediate_viewport( | |||
| input | |||
| }; | |||
|
|
|||
| let egui_ctx = shared.borrow().egui_ctx.clone(); | |||
There was a problem hiding this comment.
What is this borrow() that caused performance problems?
There was a problem hiding this comment.
Improvement : In glow and wgpu, we are removing egui_ctx and only using integration.egui_ctx.
Fix Issues: On Windows, we should use EventResult::RepaintNow() in Immediate Viewport to avoid FPS slowdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Issues : Speed issues on Windows when immediate viewport is on another screen
On Windows, we should use
EventResult::RepaintNow()inImmediate Viewportto avoid FPS slowdown.Improvement : In
glowandwgpu, we are removingegui_ctxand only usingintegration.egui_ctx.This simplifies the structure and reduces the possibility of bugs.
immediate viewportis on another screen #5249