Consume escape keystroke when bailing out from a drag operation #5433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview available at https://egui-pr-preview.github.io/pr/5433-antoine/dnd-consume-escape |
abey79
added a commit
that referenced
this pull request
Dec 9, 2024
emilk
pushed a commit
that referenced
this pull request
Dec 9, 2024
I introduced this in #5433. TL;DR: there are two termination conditions for drag-and-drop operations: - ESC - release mouse The former _must_ happen at frame start (to properly capture the keystroke). The latter _must_ happen at end-of-frame (to _not_ shadow the mouse release event from user code). This is now properly documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consume the escape keystroke when it's used to bail out of a drag-and-drop operation.
Successfully tested with rerun (aka
ESCaping from a drag no longer deselects the current selection).