fix: add "main" entry to package.json #457
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Closes #456
What has been done:
According to Node.js documentation only on older versions of Node.js should
main
be required.Regardless, Parcel doesn't seem to honor the sole existence ofexports
(withoutmain
). This change will support both by allowingexports
to take precedence per the above.UPDATE: Seems like the issue could be due to conditional exports not supported in Parcel. I think this is good justification to add the
main
entry as a fallback for when conditional exports is not supported (like in the case of Parcel).