fix: custom loading icon not showing #468
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR addresses the issue of custom loading icons not displaying correctly. By introducing a
LoadingWrappercomponent, we ensure that custom loading icons are properly wrapped with the necessarysonner-loading-wrapperclass, allowing them to be displayed as intended.What has been done:
Summary
These changes improve the flexibility and usability of the loading icon feature, allowing for custom icons to be seamlessly integrated.
Screenshots/Videos:
Video of error
loading_icon_not_showing_before_implementation.mov
Video of fix
loading_icon_showing_after_resolving_error.mov