Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer is jittery scrolling down when modal={false} is set #253

Closed
ghost opened this issue Feb 2, 2024 · 4 comments
Closed

Drawer is jittery scrolling down when modal={false} is set #253

ghost opened this issue Feb 2, 2024 · 4 comments

Comments

@ghost
Copy link

ghost commented Feb 2, 2024

https://codesandbox.io/p/devbox/nested-modal-with-input-2-6wt446

Repro:

  • Open https://6wt446-3000.csb.app/
  • Open dev tools and go into mobile mode (or visit on your phone)
  • Open the drawer
  • Try to close the drawer by scrolling down when at the top

Expected: Drawer will close as it does when modal={true}.
Seen: Drawer doesn't close and jitters and gets stuck.

@emilkowalski
Copy link
Owner

Does it only happen when the modal prop is set to false?

@ghost
Copy link
Author

ghost commented Feb 5, 2024 via email

@predaytor
Copy link

Can confirm this. modal={false} is broken currently.

@emilkowalski
Copy link
Owner

Should be fixed in #424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants