Batch fixed position style updates #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rortan134 is attempting to deploy a commit to the emil Team on Vercel. A member of the Team first needs to authorize it. |
rortan134
commented
May 5, 2024
| export function set(el?: Element | HTMLElement | null, styles?: Style, ignoreCache = false) { | ||
| if (!el || !(el instanceof HTMLElement) || !styles) return; | ||
| export function set(el: Element | HTMLElement | null | undefined, styles: Style, ignoreCache = false) { | ||
| if (!el || !(el instanceof HTMLElement)) return; |
There was a problem hiding this comment.
styles is always defined in the codebase so this check is redundant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating multiple inline styles at once can be done more efficiently with Object.assign. This portion of code was causing quite a few recalculation renders on some browsers