fix: drawer failing to cancel move event #339
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rortan134 is attempting to deploy a commit to the emil Team on Vercel. A member of the Team first needs to authorize it. |
rortan134
commented
May 5, 2024
|
|
||
| React.useEffect(() => { | ||
| // Trigger enter animation without using CSS animation | ||
| setVisible(true); | ||
| }, []); | ||
|
|
||
| const isDeltaInDirection = (delta: { x: number; y: number }, direction: DrawerDirection, threshold = 0) => { | ||
| function isDeltaInDirection(delta: { x: number; y: number }, direction: DrawerDirection, threshold = 0) { |
There was a problem hiding this comment.
changed to regular function for the sake of consistency
joaom00
reviewed
May 8, 2024
src/index.tsx
Outdated
Comment on lines
1051
to
1052
| onPointerOut={handleOnPointerUp} | ||
| onContextMenu={handleOnPointerUp} |
There was a problem hiding this comment.
We need to forward the events to these too
|
I think the events are not being forwarded yet. I'm talking specifically about this line rest.onPointerUp?.(event);We need to rest.onPointerOut?.(event)
rest.onContextMenu?.(event)depending on the prop |
|
Added in #440 due to too many merge conflicts, it's my bad that I didn't merge this earlier. Thanks for your contribution though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #279