New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE-369: Make vaul use data- attr for Content direction #404

Merged

emilkowalski merged 4 commits into emilkowalski:main from mikita-liaukovich-epam:ISS-369_tailwind_data_attr

Sep 7, 2024

Contributor

mikita-liaukovich-epam commented Sep 6, 2024

Related issue: 369

This PR makes vaul use common data-attribute for content direction. This allows usage of Tailwind classes to style the Drawer differently for different directions.
The typo vault is fixed in style.css

mikita-liaukovich-epam added 2 commits

September 6, 2024 14:45


          [ISSUE-369] Make vaul use data- attributes to allow TW for Content st…

43a188f

…yling


          [ISSUE-369] Fix vault typo in vaul styles

c381163

vercel bot commented Sep 6, 2024

@mikita-liaukovich-epam is attempting to deploy a commit to the emil Team on Vercel.

A member of the Team first needs to authorize it.


          [ISS-369] Revert drawer-visible attr as not relevant

60cf280

Owner

emilkowalski commented Sep 7, 2024

This is great, thank you!

Could we do that for all attributes? I can imagine people would want to style other ones as well.


          [ISSUE-369] Update all custom vaul attributes to be data-attrs

efa2eab

Contributor Author

mikita-liaukovich-epam commented Sep 7, 2024

@emilkowalski done! I updated all custom vaul- attributes with data-vaul-

Owner

emilkowalski commented Sep 7, 2024

Thank you so much @mikita-liaukovich-epam

emilkowalski merged commit 2ae6cf7 into emilkowalski:main

1 check failed

mikita-liaukovich-epam mentioned this pull request

Should vaul use standard data attribute? #369

Closed

kodiakhq bot referenced this pull request in technifit/tasker


          fix(deps): update dependency vaul to v0.9.3 (#1007)

776e94f

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [vaul](https://vaul.emilkowal.ski/) ([source](https://redirect.github.com/emilkowalski/vaul)) | [`0.9.2` -> `0.9.3`](https://renovatebot.com/diffs/npm/vaul/0.9.2/0.9.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/vaul/0.9.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/vaul/0.9.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/vaul/0.9.2/0.9.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/vaul/0.9.2/0.9.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>emilkowalski/vaul (vaul)</summary>

### [`v0.9.3`](https://redirect.github.com/emilkowalski/vaul/releases/tag/v0.9.3)

[Compare Source](https://redirect.github.com/emilkowalski/vaul/compare/v0.9.2...v0.9.3)

#### What's Changed

Most importantly the scroll top issue should now be gone, issues with controlled state/defaultOpen prop should also be fixed.

-   feat: add export on props by [@&#8203;ferdylimmm9](https://redirect.github.com/ferdylimmm9) in [https://github.com/emilkowalski/vaul/pull/405](https://redirect.github.com/emilkowalski/vaul/pull/405)
-   adjust snapPoints on window resize by [@&#8203;bviebahn](https://redirect.github.com/bviebahn) in [https://github.com/emilkowalski/vaul/pull/399](https://redirect.github.com/emilkowalski/vaul/pull/399)
-   Export DialogProps type by [@&#8203;martynaskadisa](https://redirect.github.com/martynaskadisa) in [https://github.com/emilkowalski/vaul/pull/348](https://redirect.github.com/emilkowalski/vaul/pull/348)
-   fix: scroll top by [@&#8203;emilkowalski](https://redirect.github.com/emilkowalski) in [https://github.com/emilkowalski/vaul/pull/406](https://redirect.github.com/emilkowalski/vaul/pull/406)
-   ISSUE-369: Make vaul use data- attr for Content direction by [@&#8203;mikita-liaukovich-epam](https://redirect.github.com/mikita-liaukovich-epam) in [https://github.com/emilkowalski/vaul/pull/404](https://redirect.github.com/emilkowalski/vaul/pull/404)
-   fix: controlled state by [@&#8203;emilkowalski](https://redirect.github.com/emilkowalski) in [https://github.com/emilkowalski/vaul/pull/408](https://redirect.github.com/emilkowalski/vaul/pull/408)
-   refactor: background scaling by [@&#8203;emilkowalski](https://redirect.github.com/emilkowalski) in [https://github.com/emilkowalski/vaul/pull/409](https://redirect.github.com/emilkowalski/vaul/pull/409)
-   feat: add prop to disable input repositioning by [@&#8203;emilkowalski](https://redirect.github.com/emilkowalski) in [https://github.com/emilkowalski/vaul/pull/410](https://redirect.github.com/emilkowalski/vaul/pull/410)

#### New Contributors

-   [@&#8203;ferdylimmm9](https://redirect.github.com/ferdylimmm9) made their first contribution in [https://github.com/emilkowalski/vaul/pull/405](https://redirect.github.com/emilkowalski/vaul/pull/405)
-   [@&#8203;bviebahn](https://redirect.github.com/bviebahn) made their first contribution in [https://github.com/emilkowalski/vaul/pull/399](https://redirect.github.com/emilkowalski/vaul/pull/399)
-   [@&#8203;martynaskadisa](https://redirect.github.com/martynaskadisa) made their first contribution in [https://github.com/emilkowalski/vaul/pull/348](https://redirect.github.com/emilkowalski/vaul/pull/348)
-   [@&#8203;mikita-liaukovich-epam](https://redirect.github.com/mikita-liaukovich-epam) made their first contribution in [https://github.com/emilkowalski/vaul/pull/404](https://redirect.github.com/emilkowalski/vaul/pull/404)

**Full Changelog**: emilkowalski/vaul@v0.9.2...v0.9.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/technifit/tasker).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet