Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parse uid for /proc/net/{tcp,udp} #231

Merged
merged 1 commit into from
Jan 8, 2023

Conversation

trinity-1686a
Copy link
Contributor

Hi,

I was evaluating this crate for my use case, and it happens to skip over the exact bit of data I'm interested in.

I also added some #[non_exhaustive] on structures where some columns are skipped over, so that parsing these in the future isn't a breaking change semver-wise

@trinity-1686a
Copy link
Contributor Author

hum, CI is unhappy but it looks like it's not related to my changes. Sleeping 30ms might not always be enough in test_proc_alive

@eminence
Copy link
Owner

eminence commented Jan 8, 2023

Yeah, I think that 30ms sleep needs to be bumped up. The test passed on re-run. Thanks for the PR, I'm not sure why I ignored UID in the first place. This LGTM

@eminence eminence merged commit 64c8664 into eminence:master Jan 8, 2023
@trinity-1686a trinity-1686a deleted the tcp-udp-uid branch January 8, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants