Remove lazy-static dependency #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lazy-static is on its way to being deprecated. I'm trying to remove it from my dependency tree. Therefore I've removed lazy-static from this crate in this commit. Modifications made: - PAGESIZE and TICKS_PER_SECOND appear to be unused so I've removed them. - KERNEL can be replaced with racy atomic initialization. - RANDOM_ROOT doesn't really need to be allocated on the heap, so I've replaced it with manual Path::new. Signed-off-by: John Nunley <dev@notgull.net>
|
Thanks, on quick skim this looks good, will review more carefully later |
|
@eminence Have you had a chance to review this more carefully? |
|
LGTM, thanks! |
I'm always curious to know where/how |
I was taking |
|
@eminence Are you planning on making a release with this change? |
|
Let me try to get a release out in a day or so |
|
This is now published at 0.17.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lazy-static is on its way to being deprecated. I'm trying to remove it
from my dependency tree. Therefore I've removed lazy-static from this
crate in this commit.
Modifications made:
them.
replaced it with manual Path::new.