fix panels for Tabs in create and update views. fixes #85 #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RVxLab
requested changes
Jan 31, 2021
|
@RVxLab I refactored the function to use each() on fields collection. That solved other issues as well. Please review. |
RVxLab
approved these changes
Feb 2, 2021
|
Looks good and seems to work well on Nova 3.21. Thanks for your PR! One question before I merge though, what exactly do you mean with this?
Are you saying that lines 3 through 16 can be removed? If yes, then perfect. Otherwise, please explain. |
|
@RVxLab yes. |
|
I'll fix that on my end. Thanks again! |
RVxLab
added a commit
that referenced
this pull request
Feb 2, 2021
Removed now unneeded fieldsOutsideTabs, see #139
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue in Update or Create view when all tabs panels were bunched into one default. Issue #85
It also makes 'fieldsOutsideTabs' in FormTabs.vue obsolete as any fields that are not included in Tabs will be shown on default Panel