Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto open first tab #165

Merged
merged 1 commit into from
Feb 13, 2022
Merged

Auto open first tab #165

merged 1 commit into from
Feb 13, 2022

Conversation

miki131
Copy link
Contributor

@miki131 miki131 commented Oct 26, 2021

No description provided.

@RVxLab
Copy link
Collaborator

RVxLab commented Feb 9, 2022

What problem are you aiming to solve with this?

@miki131
Copy link
Contributor Author

miki131 commented Feb 9, 2022

I have a lot of tabs on user page which are relations and I don't want them open on page load but only when I click on tab myself

@RVxLab
Copy link
Collaborator

RVxLab commented Feb 9, 2022

In the sense of lazy loading?

If so then this is a good idea! Can you rebase this please?

@miki131
Copy link
Contributor Author

miki131 commented Feb 9, 2022

Done.

@RVxLab
Copy link
Collaborator

RVxLab commented Feb 9, 2022

Thanks! I’ll check this out when I can.

@miki131
Copy link
Contributor Author

miki131 commented Feb 12, 2022

Could you please review and merge?

@RVxLab RVxLab merged commit 9fc77c9 into eminiarts:master Feb 13, 2022
@RVxLab
Copy link
Collaborator

RVxLab commented Feb 13, 2022

Just had a look, it works well! I'm going to add a convenience method to this as an addition.

Thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants