Remove redundant h1 selector #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule affects several WYSIWYG editors. Fixes: #159
|
I’ll trust you on your word. Thanks for the PR! |
|
This selector turned out not to be redundant unfortunately. This is what happened on a fresh Nova installation:
I'll (partially) revert this change. |
RVxLab
added a commit
that referenced
this pull request
Feb 13, 2022
|
Sorry it actually did break something, but glad to see you came up with an appropriate fix! Strange thing is that I can't reproduce what you see in a fresh installation (Laravel 8.83.0, Nova 3.31.0, nova-tabs 1.4.6 + my patch) 🤔 |
That's very strange indeed 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed the redundant h1 selector as mentioned in #159. I don't have concrete evidence this doesn't break anything, other than that I've tested it in a real application and didn't find any issues.
Resolves #159