Remember current tab #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bajramemini: Any chance to get merged? |
|
I support this merge request :) |
|
+1 for merge request |
|
Still not merged? |
😧 I know, right!? |
|
Sorry it has taken this long to address this. I'll take a look at it and come back to you. |
|
+1 Deep linking would be fantastic. |
RVxLab
requested changes
Oct 20, 2020
| @@ -119,6 +114,7 @@ export default { | |||
| handleTabClick(tab, event) { | |||
| tab.init = true; | |||
| this.activeTab = tab.name; | |||
| this.$router.push({ query: { tab: tab.name }}); | |||
There was a problem hiding this comment.
Can you also add a replace here like in FormTabs.vue?
There was a problem hiding this comment.
I hope I understand it right, but I have done the change (and the merge of master into my remember-current-tab branch)
RVxLab
approved these changes
Oct 21, 2020
|
Perfect, thank you very much! |
|
Sorry to be impatient but what is the release time schedule for a change like this? :) |
|
@keironwaites I want to add at least 1 more bugfix, see #23. I'm aiming this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this solution, you can for example reload (
CTRL+R) the edit and detail views or you can submit the form page and you will get the previous openend tab back again. And you can also deeplink specific tabs.