Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had trouble building my CLI app with diesel/openssl support. Turns out it does matter the order of
extern crate foo;
does matter. While I threw everything possible at the wall, I tried building my own rust-musl-builder image.One of the g++ dependency was failing to install, owing to something wrong in the Ubuntu archives no doubt. And I use bionic elsewhere in my infrastructure so I thought it would be helpful to upgrade to a new LTS release. It was pretty easy, the biggest change is dragging in gcc8 libraries vs 4.7.
I also upgrade the custom built dependencies. OpenSSL gets LTS release
1.0.2q
, postgres gets bumped to9.6.9
.I don't think the linked issue rust-lang/rust#34978 matters anymore. I have successfully built using this image and I'm happy with it.
Also, pro-tip to anyone who wants to build their own rust-musl for nightly, use docker build's build-args to override the toolchain: