Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: don't delay deleting input files during writing when moving #1320

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

emmercm
Copy link
Owner

@emmercm emmercm commented Aug 28, 2024

No description provided.

@emmercm emmercm self-assigned this Aug 28, 2024
@emmercm emmercm marked this pull request as ready for review August 28, 2024 01:31
@emmercm emmercm enabled auto-merge (squash) August 28, 2024 01:31
@emmercm emmercm merged commit 20dae09 into emmercm/3.0.0-feature Aug 28, 2024
54 checks passed
@emmercm emmercm deleted the emmercm/immediate-file-moves-fix branch August 28, 2024 01:54
Copy link

🧪 Branch testing instructions

This pull request has been merged, its base branch can be tested locally with the following command:

npm exec --yes -- "github:emmercm/igir#emmercm/3.0.0-feature" [commands..] [options]

Comment generated by the Node.js Branch Exec workflow.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (emmercm/3.0.0-feature@02b0f61). Learn more about missing BASE report.

Files Patch % Lines
src/modules/candidateWriter.ts 0.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@                   Coverage Diff                    @@
##             emmercm/3.0.0-feature    #1320   +/-   ##
========================================================
  Coverage                         ?   92.84%           
========================================================
  Files                            ?      118           
  Lines                            ?     7452           
  Branches                         ?     1802           
========================================================
  Hits                             ?     6919           
  Misses                           ?      509           
  Partials                         ?       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

🔒 Inactive pull request lock

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Comment generated by the GitHub Lock Issues workflow.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant