We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
the function get_by_label does not check the type of the label provided. it then crashes if a float is provided
this case appeared because when reading from an Excel sheet the list of prefLabel, an empty cell is read as a float (NaN).
The text was updated successfully, but these errors were encountered:
Do you think we should check if label is str and return a TypeError if not?
Sorry, something went wrong.
Yes it could be a first step.
Later I think that we should test if the submitted string is a valid label if there are rules for that.
That we already do. If you ask for a label to does not exist it return NoSuchLabelError.
closed with #312
No branches or pull requests
the function get_by_label does not check the type of the label provided. it then crashes if a float is provided
this case appeared because when reading from an Excel sheet the list of prefLabel, an empty cell is read as a float (NaN).
The text was updated successfully, but these errors were encountered: