Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added checking that label is string in get_by_label #312

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Added checking that label is string in get_by_label #312

merged 2 commits into from
Dec 1, 2021

Conversation

francescalb
Copy link
Collaborator

@francescalb francescalb commented Dec 1, 2021 •
edited by sygout
Loading

Description:

Checkin that label is actually a string

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@francescalb francescalb merged commit dce92c0 into master Dec 1, 2021
@francescalb francescalb deleted the flb/close-311-return_error_if_get_by_label_not_string branch December 1, 2021 14:49
@francescalb francescalb mentioned this pull request Dec 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sygout sygout sygout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francescalb @sygout