Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge without label crash the graph creation #397

Closed
sygout opened this issue Apr 6, 2022 · 1 comment · Fixed by #414
Closed

Edge without label crash the graph creation #397

sygout opened this issue Apr 6, 2022 · 1 comment · Fixed by #414
Assignees
Labels
bug Something isn't working

Comments

@sygout
Copy link
Collaborator

sygout commented Apr 6, 2022

In the examples of visualization in Jupyter, the code crash here:
cytograph = cytoscapegraph(graph, onto=onto, infobox='right')

In the function cytoscapegraph, the graph is explored to go through the edges list:
data = cytoscape_data(pydot_graph)["elements"]
for datum in data["edges"]:
datum["data"]["label"]

There is no test that a key "label" is present.
Some of edges do not have label: {'data': {'arrowhead': 'empty', 'source': 'SINTEFPerson', 'target': 'Person', 'key': 0}}
A fix is to make a test if "label" in datum["data"]: and ignore all the edges without label

@sygout sygout added the bug Something isn't working label Apr 6, 2022
@francescalb
Copy link
Collaborator

This is due to graphs in in OntoGraoh no longer being generated with edgelabels=True as default.

To do: Change to edgelabel=True in the example jupyter lab notebook,

and return an error that explains to do if labels are missing.

@francescalb francescalb self-assigned this May 19, 2022
@francescalb francescalb linked a pull request May 23, 2022 that will close this issue
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants