Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cytoscapegraph fails with missing edge labels #414

Merged
merged 2 commits into from
May 23, 2022
Merged

cytoscapegraph fails with missing edge labels #414

merged 2 commits into from
May 23, 2022

Conversation

francescalb
Copy link
Collaborator

@francescalb francescalb commented May 19, 2022 •
edited by sygout
Loading

Description:

closes #412 #397

Graph given as parameter should be generated with edgelabel = True
(this was default previously).

This has been documented, and the overall docuementation improved.

Error on providing this is returned as an EMMOntoPyException with explanation.

Adding the parameter force will make a graph with incorrect edges and an error stating this.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@francescalb
visualisation with cytoscapewidget improved with documentation.
03ca9b7 
Graph given as parameter should be generated with edgelabel = True
(this was default previously).
@francescalb francescalb changed the title cytoscapegraph fails with missing edge labels WIP: cytoscapegraph fails with missing edge labels May 19, 2022
@francescalb francescalb changed the title WIP: cytoscapegraph fails with missing edge labels cytoscapegraph fails with missing edge labels May 23, 2022
@francescalb francescalb requested a review from sygout May 23, 2022 08:37
@francescalb francescalb linked an issue May 23, 2022 that may be closed by this pull request
Edge without label crash the graph creation #397
Closed
@francescalb francescalb merged commit 6c168fd into master May 23, 2022
@francescalb francescalb deleted the flb/issue397 branch May 23, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sygout sygout sygout approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

visualization of EMMO based ontology Edge without label crash the graph creation
2 participants
@francescalb @sygout