Remove sub-fact++ modules importability #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasperWA
changed the title
I.e., remove them as Python importable modules. Ensure all files are still included in the package build.
Fixed factpluspluswrapper for rdflib < 5.0.0. The `replace` parameter did not become available through the `bind()` method until rdflib v5.0.0, however, the functionality is there. Since the `bind()` method is just a proxy method for the same named method for the `namespace_manager`, this can be used instead. Note, it is imperative that Java is installed for this to work.
This is needed to test `emmo.sync_resolver()`.
CasperWA
force-pushed
the
cwa/close-213-factpluspluswrapper-importability
branch
from
e5c95ef
to
8f8bb2b
Compare
|
This has been done now, I think, @francescalb. |
francescalb
approved these changes
Sep 21, 2021
CasperWA
deleted the
cwa/close-213-factpluspluswrapper-importability
branch
CasperWA
added a commit
that referenced
this pull request
Sep 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e., remove them as Python importable modules.
Ensure all files are still included in the package build.
Closes #213.
Note, this is a remake of #214, but using a branch from this repository instead of a fork.