-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added function to load the emmo (the ontology) directly #226
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is quite nice.
My comments are mainly for some typing tricks and such, not really the content.
Another thing I was thinking though was whether it should be named in capitals, where possible, instead of the lower case letters?
Not a bad idea, it's still a bit confusing I think. from emmopy import EMMO Which would mean we could simply create an What I'm trying to say is, it might be best to rename to from emmopy import get_emmo
EMMO = get_emmo(inferred=False)
EMMO_inferred = get_emmo() |
I think get_emmo is better, since using |
Good suggestions from Casper. Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge at will if/when tests pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Par excellence
Closes #209.
We could call it get_emmo instead.