Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from collections.abc when possible #240

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

CasperWA
Copy link
Collaborator

Description:

Fixes #236.

Importing ABCs from collections is deprecated and will be removed in Python 3.10.

As a note, I ran pytest and checked the resulting Python warnings. The only ones left are DeprecationWarnings the package raises itself.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

Importing ABCs from collections is deprecated and will be removed in
Python 3.10.
Co-authored-by: francescalb <48128015+francescalb@users.noreply.github.com>
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

@CasperWA CasperWA merged commit 179f78f into master Sep 28, 2021
@CasperWA CasperWA deleted the cwa/fix-236-collections-warning branch September 28, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Warning" Importing from collections
2 participants