Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Standard methods to Ontology #246

Merged
merged 16 commits into from
Nov 2, 2021
Merged

Added Standard methods to Ontology #246

merged 16 commits into from
Nov 2, 2021

Commits on Oct 25, 2021

  1. Added __hash__ and __eq__ to ontology.Ontology

    @francescalb
    francescalb committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    7e2499c View commit details
    Browse the repository at this point in the history

  2. Sorting emmo classes with iris does not work. checkout

    @francescalb
    francescalb committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    7e6ab17 View commit details
    Browse the repository at this point in the history

  3. Added test for ontology equality

    @francescalb
    francescalb committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    180a05a View commit details
    Browse the repository at this point in the history

  4. Creating hash and testing ontology equality 

    It now works, but only when the test includes checking for classes
and base_iri of the ontology. The test does not include properties.
    @francescalb
    francescalb committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    475683d View commit details
    Browse the repository at this point in the history

  5. Extended possibilities for ThingClass hash 

    Preffered is hash on iri, second, try prefLabel, third try name
fourth try label
    @francescalb
    francescalb committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    3b6585e View commit details
    Browse the repository at this point in the history

  6. Only hash on iri for ThingClass in hash, and ontology hash including 

    everything except annotation_properties and Individuals
    @francescalb
    francescalb committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    d2ad916 View commit details
    Browse the repository at this point in the history

  7. Sorting emmo classes with iris does not work.

    @francescalb @CasperWA
    francescalb authored and CasperWA committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    63513fe View commit details
    Browse the repository at this point in the history

  8. Only use iri for calculating the hash

    @francescalb @CasperWA
    francescalb authored and CasperWA committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    3fa0e52 View commit details
    Browse the repository at this point in the history

  9. Added __eq__ in Ontology based on triples 

    Note that consistency of blank nodes is not checked.
    @francescalb
    francescalb committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    4b08fa6 View commit details
    Browse the repository at this point in the history

  10. Added testing of new relation

    @francescalb
    francescalb committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    61011d5 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2021

  1. Name of inferred ontology not shortened any longer 

    Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
    @francescalb @CasperWA
    francescalb and CasperWA committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    b7371d0 View commit details
    Browse the repository at this point in the history

  2. Removed helper function to sort entities as it is no longer needed

    @francescalb
    francescalb committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    14ff1c2 View commit details
    Browse the repository at this point in the history

  3. Improved on return of dummy variables 

    Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
    @francescalb @CasperWA
    francescalb and CasperWA committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    b8e700d View commit details
    Browse the repository at this point in the history

  4. Clarify documentation of __eq__ for Ontology

    @francescalb
    francescalb committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    1da61a5 View commit details
    Browse the repository at this point in the history

  5. write out short names and skip unnecessary intermediate variables 

    Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
    @francescalb @CasperWA
    francescalb and CasperWA committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    76edb29 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2021

  1. Too long line with long variable names fixed

    @francescalb
    francescalb committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    1ea3bc9 View commit details
    Browse the repository at this point in the history