Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new test "test_physical_quantity_dimension" #258

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Oct 17, 2021

It checks for hasPhysicalProperty restriction in upcoming EMMO. For now it is turned off by default.

Also added options to enable tests that are skipped by default.

Description:

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

It checks for hasPhysicalProperty restriction in upcoming EMMO.  For now it is
turned off by default.

Also added options to enable tests that are skipped by default.
@jesper-friis jesper-friis linked an issue Oct 17, 2021 that may be closed by this pull request
@francescalb
Copy link
Collaborator

Is there an EMMO-version that this test can be tried on now?

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, but difficult to test without this new EMMO-version, should be tested properly once this is in place.

Can be approved once documentation is up to date.

@jesper-friis
Copy link
Collaborator Author

This new version of EMMO is available in the EMMO 1.0.0-beta2 branch: https://github.com/emmo-repo/EMMO/tree/1.0.0-beta2

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and test works.

@jesper-friis jesper-friis merged commit 64c96cb into master Oct 25, 2021
@CasperWA CasperWA deleted the issue257-emmocheck branch March 2, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test to emmocheck for upcoming EMMO
2 participants