Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed link to OpenModel logo #279

Merged
merged 3 commits into from
Nov 2, 2021
Merged

Conversation

francescalb
Copy link
Collaborator

Description:

Fixed link to OpenModel logo in README.md
Closes #278

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@CasperWA
Copy link
Collaborator

CasperWA commented Nov 2, 2021

See here: You must run invoke create-docs-index and git add and commit the updated docs/index.md file :)

@CasperWA
Copy link
Collaborator

CasperWA commented Nov 2, 2021

Note, if the invoke command doesn't work, remember to install the "docs" extra for this repository, i.e., pip install -e .[docs] :)

@francescalb
Copy link
Collaborator Author

I had completely forgotten :( Fixed now I think.

@CasperWA
Copy link
Collaborator

CasperWA commented Nov 2, 2021

I had completely forgotten :( Fixed now I think.

No worries - this is why we have the CI :) It also tells you what to do, I just reiterated it here as a comment.

Copy link
Collaborator

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ! Seems to come through as it should. Thanks @francescalb 🚀

@francescalb francescalb merged commit f3f0ba7 into master Nov 2, 2021
@CasperWA CasperWA deleted the flb/close-278-OpenModelLogo branch March 2, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenModel logo not loading in README
2 participants