Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update method name to avoid overwriting inherited #281

Merged
merged 3 commits into from
Nov 2, 2021
Merged

Update method name to avoid overwriting inherited #281

merged 3 commits into from
Nov 2, 2021

Conversation

CasperWA
Copy link
Collaborator

@CasperWA CasperWA commented Nov 2, 2021

Description:

Fixes #280

Rename ontopy.ontology.Ontology.get_triples() to
get_unabbreviated_triples() to avoid overwriting the inherited
get_triples() method.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@CasperWA
Update method name to avoid overwriting inherited
b998fd4 
Rename `ontopy.ontology.Ontology.get_triples()` to
`get_unabbreviated_triples()` to avoid overwriting the inherited
`get_triples()` method.
@CasperWA
Copy link
Collaborator Author

CasperWA commented Nov 2, 2021

Following the discussion in #280 this is now ready for review :)

francescalb
francescalb approved these changes Nov 2, 2021
View reviewed changes
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted. Thanx!

@CasperWA CasperWA merged commit cd7fc04 into master Nov 2, 2021
@CasperWA CasperWA deleted the cwa/fix-280-get_triples branch November 2, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francescalb francescalb francescalb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overwriting get_triples() method
2 participants
@CasperWA @francescalb