-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add logo to Readme and doc #289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but please make these links relative and avoid fencing it in a p
tag - there is no need, use instead the align
attribute of the img
tag. Furthermore, it will probably look nicer if it's aligned right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, but I did not understand what you mean :) |
left align logo and move it to the first row
README.md
Outdated
# EMMOntoPy | ||
|
||
|
||
<img src="docs/images/suspected_logo.png" width="40%" align="middle"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# EMMOntoPy | |
<img src="docs/images/suspected_logo.png" width="40%" align="middle"> | |
<img src="docs/images/suspected_logo.png" width="40%" align="right"> | |
# EMMOntoPy | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what I meant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason to add extra lines. After this this looks great :)
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great - thank you @m-abdollahi ! :)
ADD logo to README and DOC index.md
Description:
Type of change:
Checklist:
This checklist can be used as a help for the reviewer.
Comments: