Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logo to Readme and doc #289

Merged
merged 15 commits into from
Nov 12, 2021
Merged

add logo to Readme and doc #289

merged 15 commits into from
Nov 12, 2021

Conversation

m-abdollahi
Copy link
Contributor

ADD logo to README and DOC index.md

Description:

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

ADD logo to README and DOC index.md
@CasperWA CasperWA self-requested a review November 9, 2021 15:59
Copy link
Collaborator

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but please make these links relative and avoid fencing it in a p tag - there is no need, use instead the align attribute of the img tag. Furthermore, it will probably look nicer if it's aligned right.

Copy link
Collaborator

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this line up to be the first line in README.md as this doesn't look very good at the moment:
image

Please also run:

pip install pre-commit invoke
SKIP=pylint pre-commit run --all-files

And commit the changed files afterwards.

@CasperWA CasperWA linked an issue Nov 10, 2021 that may be closed by this pull request
@m-abdollahi
Copy link
Contributor Author

m-abdollahi commented Nov 10, 2021

Okay, but I did not understand what you mean :)
actually, I think due to align att and without p tag, we can't leave it alone in a single row! we can make it align left and its gonna be ok

left align logo and move it to the first row
README.md Outdated
Comment on lines 1 to 4
# EMMOntoPy


<img src="docs/images/suspected_logo.png" width="40%" align="middle">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# EMMOntoPy
<img src="docs/images/suspected_logo.png" width="40%" align="middle">
<img src="docs/images/suspected_logo.png" width="40%" align="right">
# EMMOntoPy

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what I meant.

Copy link
Collaborator

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason to add extra lines. After this this looks great :)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
CasperWA and others added 5 commits November 11, 2021 14:06
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
Copy link
Collaborator

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great - thank you @m-abdollahi ! :)

@CasperWA CasperWA merged commit 49de67c into emmo-repo:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add logo to README
2 participants