Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for label name length in ontology.new_entity #291

Merged
merged 4 commits into from
Nov 10, 2021

Conversation

francescalb
Copy link
Collaborator

Description:

Added check that the label of a new entity consists of only one word in ontology.new_entity.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

Copy link
Collaborator

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

Are all entities ThingClass? Great to know. This should be the default type for entities throughout the code in the future then. Or do we have a more EMMOntoPy-specific class?

Concerning the two suggested changes only the one for the error message is important.
And no need to include me as contributing author for these changes. I suggest just squash-merging and removing my name from the commit message 👍

ontopy/ontology.py Outdated Show resolved Hide resolved
ontopy/utils.py Outdated Show resolved Hide resolved
francescalb and others added 2 commits November 10, 2021 14:42
Co-authored-by: Casper Welzel Andersen <43357585+CasperWA@users.noreply.github.com>
@francescalb francescalb merged commit eb5146d into master Nov 10, 2021
@CasperWA CasperWA deleted the flb/new_entity_check_for_labelname branch March 2, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants