Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for evaluating Manchester expression to owlready2 #296

Merged
merged 15 commits into from
Nov 25, 2021
Merged

Added support for evaluating Manchester expression to owlready2 #296

merged 15 commits into from
Nov 25, 2021

Conversation

jesper-friis
Copy link
Collaborator

Description:

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@jesper-friis jesper-friis linked an issue Nov 20, 2021 that may be closed by this pull request
Make ManchesterSyntaxParser that returns Owlready2 #293
Closed
francescalb
francescalb reviewed Nov 22, 2021
View reviewed changes
ontopy/manchester.py Outdated Show resolved Hide resolved
jesper-friis and others added 5 commits November 22, 2021 23:50
@jesper-friis
Added more comments as suggested by Francesca
6ec1483 
Also polluted it with a lot of "pylint: disable=..." in order to commit...
@jesper-friis
Added a test_manchester() function
1992e6a
@jesper-friis
Fixed issues blocking pre-commit
4181384
@jesper-friis
Added return type annotation to ontopy.manchester.evaluate()
a546ae2
@jesper-friis
Update manchester.py
746db63 
Added parseAll=True to pyparsing parseString() to get an exception for invalid expressions
francescalb
francescalb reviewed Nov 24, 2021
View reviewed changes
ontopy/manchester.py Outdated Show resolved Hide resolved
francescalb
francescalb approved these changes Nov 25, 2021
View reviewed changes
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good now!

@jesper-friis jesper-friis merged commit bebe435 into master Nov 25, 2021
@CasperWA CasperWA deleted the parse-manchester-syntax branch March 2, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CasperWA CasperWA CasperWA left review comments

@francescalb francescalb francescalb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make ManchesterSyntaxParser that returns Owlready2
3 participants
@jesper-friis @CasperWA @francescalb