Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialised ontology iri #341

Merged
merged 4 commits into from
Jan 5, 2022
Merged

Conversation

jesper-friis
Copy link
Collaborator

Description:

Serialised ontologies has IRI http://emmo.info/emmo/domain/onto.
Assigning onto.base_iri seems not to be sufficient to change that.
An easy solution is to create the ontology with the correct base IRI from the start.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

Serialised ontologies has IRI http://emmo.info/emmo/domain/onto.
Assigning onto.base_iri seems not to be sufficient to change that.
An easy solution is to create the ontology with the correct base
IRI from the start.
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok

@jesper-friis jesper-friis merged commit 8d22f1a into master Jan 5, 2022
@jesper-friis jesper-friis deleted the fix-serialised-ontology-iri branch January 5, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants