Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed arguments in _has_obj_triples_spo #351

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

francescalb
Copy link
Collaborator

pylint complains as it checks in the definition defined in
owlready2.namespace.Namespace (which takes subject and predicate as
arguments). The function that is actually used is defined in
owlready2.triplelite.

Description:

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

pylint complains as it checks in the definition defined in
owlready2.namespace.Namespace (which takes subject and predicate as
arguments). The function that is actually used is defined in
owlready2.triplelite.
@jesper-friis
Copy link
Collaborator

Thanks for the explanation.

@francescalb francescalb merged commit 9ce1d0c into master Jan 13, 2022
@francescalb francescalb deleted the flb/close350_get_version_bug branch January 13, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_get_triples_spo take argumens s, and p, not subject and predicate
2 participants