Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close temporary file before reading it #364

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Feb 8, 2022

Description:

Windows fails if the temporary file isn't closed.

As a workaround we close the temporary file before writing to it.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@jesper-friis jesper-friis linked an issue Feb 8, 2022 that may be closed by this pull request
@jesper-friis jesper-friis merged commit ff951b4 into master Feb 22, 2022
@jesper-friis jesper-friis deleted the close-file-before-read branch February 22, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot load ontology in Windows.
2 participants