Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoided infinite recursion when loading catalog files that recursively #370

Merged
merged 3 commits into from
Mar 2, 2022

Conversation

jesper-friis
Copy link
Collaborator

refer to each other.

This also speeds up loading of catalog files.

Description:

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

refer to each other.

This also speeds up loading of catalog files.
Copy link
Collaborator

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - cheers @jesper-friis

@CasperWA CasperWA enabled auto-merge (squash) March 2, 2022 16:06
@CasperWA CasperWA merged commit f23cfcf into master Mar 2, 2022
@CasperWA CasperWA deleted the jf/fix-369-catalog-recursion-error branch March 2, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants