-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality for setting name part of IRI to prefLabel #399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove uneccesary functions that remain in utils so that we do not do the same things wtice in two different places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also a test is needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think the has_triple and get_triples can be made as general utility functions. I suggest adding an Issue on that referring to the code here.
fix #398
Description:
Added
--rename-iris
and--annotate-source
options of ontoconvert.In order to allow combining these options with with the
--squash
,--recursive
and--reasoner
options, the--squash
and--recursive
functionality had to be moved into Ontology.save(), which made this PR ending up being quite large... It didn't became better, when I realised that the Owlready2 currently completely messes up the ontology when adding new relations from the reasoner...Changes:
recursive
,squash
andwrite_catalog_file
keyword arguments to Ontology.save()Type of change:
Checklist:
This checklist can be used as a help for the reviewer.
Comments: