Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs python handler #408

Merged
merged 2 commits into from
May 5, 2022
Merged

Conversation

CasperWA
Copy link
Collaborator

@CasperWA CasperWA commented May 5, 2022

Description:

Fixes #407

Added type annotations to functions and methods, where the signature is described (parameters/returns).

Allowing a single warning in the build documentation CI job.
This warning seems to be the fault of Owlready2.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

Added type annotations to functions and methods, where the signature is
described (parameters/returns).

Allowing a single warning in the build documentation CI job.
This warning seems to be the fault of Owlready2.
@CasperWA CasperWA added the BLOCKING This issue or PR is blocking development ! label May 5, 2022
@CasperWA CasperWA requested a review from francescalb May 5, 2022 09:07
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

@CasperWA CasperWA enabled auto-merge (squash) May 5, 2022 09:09
@CasperWA CasperWA merged commit b82e1fb into master May 5, 2022
@CasperWA CasperWA deleted the cwa/fix-407-docs-not-building branch May 5, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLOCKING This issue or PR is blocking development !
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation is currently not building
2 participants