Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved get_unabbreviated_triples() #449

Merged
merged 9 commits into from
Sep 8, 2022
Merged

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Aug 27, 2022

Description:

  • Corrected behaviour of get_unabbreviated_triples().
  • Changed add_label_annotation() to create missing label annotations instead of raising an exception.
  • Minor cleanup

PR added to support the "ontopy" triplestore backend in DLite.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write a proper issue first describing the problem. this then makes it easier to review why and how this is implemented.

@jesper-friis jesper-friis linked an issue Sep 2, 2022 that may be closed by this pull request
@jesper-friis jesper-friis merged commit 2c5f2b9 into master Sep 8, 2022
@jesper-friis jesper-friis deleted the get_unabbreviated_triples branch September 8, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behaviour of get_unabbreviated_triples()
2 participants