-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setting prefix explicitly in excelparser #470
Merged
francescalb
merged 10 commits into
master
from
467-excel2onto-add-choice-of-prefix-for-imported-ontologies
Oct 11, 2022
Merged
Setting prefix explicitly in excelparser #470
francescalb
merged 10 commits into
master
from
467-excel2onto-add-choice-of-prefix-for-imported-ontologies
Oct 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefix can now be set explicitly for imported ontologies in excelparser. Either only prefix of given ontology, or set common prefix for all ontologies with a given root in the base_iri
…ported-ontologies
…gies' of github.com:emmo-repo/EMMOntoPy into 467-excel2onto-add-choice-of-prefix-for-imported-ontologies
…ported-ontologies
jesper-friis
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice
…ported-ontologies
@francescalb I think this can be merged, and then you can try to perform a release again using all the new bells and whistles :) |
francescalb
deleted the
467-excel2onto-add-choice-of-prefix-for-imported-ontologies
branch
October 11, 2022 10:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Prefix can now be set explicitly for imported ontologies in excelparser. Either only prefix of given ontology, or set common prefix for all ontologies with a given root in the base_iri. Importing subontologies is also corrected.
The following is an image of the ImportedOntologies excelsheet.
The following image shows two new tests added in the excelparser test, in which two new classes are added. Both of these are subclasses on the locally imported testontology, either from the first import or its subontology. Note that they are given the same prefix based on the base_iri_root. If base_iri_root is not given the given prefix is only set to the main ontology and not the indirect imports. If base_iri_root is given all ontologies with their base_iri starting with base_iri_root are given the same prefix.
Type of change:
Checklist:
This checklist can be used as a help for the reviewer.
Comments: