Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added correct material.png figure in tool-instructions #498

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

francescalb
Copy link
Collaborator

Description:

Correct Figure of the material branch from emmo-1.0.0beta4.
Also added a format requirement since it did not take the .png extension automatically from the name.
This should be fixed in a dfferent PR in respons to issue #497

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@francescalb francescalb linked an issue Oct 31, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #498 (4d3fc7a) into master (64782c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #498   +/-   ##
=======================================
  Coverage   63.15%   63.15%           
=======================================
  Files          16       16           
  Lines        3078     3078           
=======================================
  Hits         1944     1944           
  Misses       1134     1134           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@francescalb francescalb merged commit e2b276d into master Oct 31, 2022
@francescalb francescalb deleted the 495-reinstate-imagesmaterialpng branch October 31, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reinstate images/material.png
3 participants