Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected so that get_by_label_all also returns all concepts #503

Merged

Conversation

francescalb
Copy link
Collaborator

@francescalb francescalb commented Nov 18, 2022

Description:

get_by_label_all did not return recently added entities before runnign sync_attributes.
This is now checked.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@francescalb francescalb linked an issue Nov 18, 2022 that may be closed by this pull request
@francescalb francescalb merged commit c414377 into master Nov 18, 2022
@francescalb francescalb deleted the 502-get_by_label_all-only-works-after-sync_attributes branch November 18, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_by_label_all only works after sync_attributes
2 participants