-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flb/fix to pylint2.15.4 #535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. You should only remove some leftover debugging statements
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #535 +/- ##
==========================================
+ Coverage 65.58% 65.59% +0.01%
==========================================
Files 16 16
Lines 3089 3090 +1
==========================================
+ Hits 2026 2027 +1
Misses 1063 1063
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want to update the pylint requirements as well, by the way?
Edit: Never mind - I now saw your comment in the issue :)
Description:
Pylint 2.15.4 introduced some new tests that were not followed.
The code has been updated accordingly.
Type of change:
Checklist:
This checklist can be used as a help for the reviewer.
Comments: