Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flb/fix to pylint2.15.4 #535

Merged
merged 5 commits into from
Feb 4, 2023
Merged

Flb/fix to pylint2.15.4 #535

merged 5 commits into from
Feb 4, 2023

Conversation

francescalb
Copy link
Collaborator

Description:

Pylint 2.15.4 introduced some new tests that were not followed.
The code has been updated accordingly.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

ontopy/ontodoc.py Outdated Show resolved Hide resolved
ontopy/ontodoc.py Outdated Show resolved Hide resolved
ontopy/ontodoc.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. You should only remove some leftover debugging statements

@codecov-commenter
Copy link

Codecov Report

Merging #535 (3a0464c) into master (751a8d5) will increase coverage by 0.01%.
The diff coverage is 60.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
+ Coverage   65.58%   65.59%   +0.01%     
==========================================
  Files          16       16              
  Lines        3089     3090       +1     
==========================================
+ Hits         2026     2027       +1     
  Misses       1063     1063              
Impacted Files Coverage Δ
ontopy/graph.py 61.63% <0.00%> (ø)
ontopy/ontology.py 70.27% <33.33%> (ø)
ontopy/patch.py 54.96% <50.00%> (+0.34%) ⬆️
ontopy/ontodoc.py 66.33% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@CasperWA CasperWA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want to update the pylint requirements as well, by the way?

Edit: Never mind - I now saw your comment in the issue :)

@francescalb francescalb linked an issue Feb 4, 2023 that may be closed by this pull request
@francescalb francescalb requested review from jesper-friis and CasperWA and removed request for CasperWA and jesper-friis February 4, 2023 18:40
@francescalb francescalb merged commit f88f721 into master Feb 4, 2023
@francescalb francescalb deleted the flb/fix_to_pylint2.15.4 branch February 4, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newest pylint (2.15.4) has intriduced some new rules.
4 participants