Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test update to PR template. #598

Merged
merged 2 commits into from
May 9, 2023
Merged

Added test update to PR template. #598

merged 2 commits into from
May 9, 2023

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Apr 30, 2023

Description:

Added test update to PR template.

Does this closes #523?

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@codecov
Copy link

codecov bot commented Apr 30, 2023

Codecov Report

Merging #598 (4a1784d) into master (d52ddb4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #598   +/-   ##
=======================================
  Coverage   67.25%   67.25%           
=======================================
  Files          16       16           
  Lines        3127     3127           
=======================================
  Hits         2103     2103           
  Misses       1024     1024           

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need colons after a subtitle?

@jesper-friis
Copy link
Collaborator Author

Why do you need colons after a subtitle?

I removed the colons. Otherwise I only added a checkbox for tests to the template.

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@francescalb francescalb enabled auto-merge May 9, 2023 19:58
@francescalb francescalb merged commit ec74440 into master May 9, 2023
@francescalb francescalb deleted the update-pr-template branch May 9, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typos in PR template
2 participants