Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation and excel sheet in example. #622

Merged
merged 2 commits into from
Jun 9, 2023

Conversation

francescalb
Copy link
Collaborator

@francescalb francescalb commented Jun 9, 2023

Description

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #622 (5f7709d) into master (61b3664) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
+ Coverage   68.43%   68.46%   +0.03%     
==========================================
  Files          16       16              
  Lines        3279     3279              
==========================================
+ Hits         2244     2245       +1     
+ Misses       1035     1034       -1     
Impacted Files Coverage Δ
ontopy/excelparser.py 81.79% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent documentation!

@francescalb francescalb merged commit 2d32537 into master Jun 9, 2023
@francescalb francescalb deleted the flb/excelparser_docupdate branch June 9, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants