Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check prefLabels in imported ontologies only if asked for. #628

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

francescalb
Copy link
Collaborator

@francescalb francescalb commented Jun 19, 2023

Description

The check for number of prefLabels was done on all classes including imported, even if imported is not given.
This is now corrected.

Also, for some reason updates in pyparsing in which methods have been renamed to python names with _ from camelcase made pylint fail, but is now fixed.

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

according to pythonification updates in pyarsing
@francescalb francescalb linked an issue Jun 19, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #628 (116f7ad) into master (e6d6e08) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #628   +/-   ##
=======================================
  Coverage   68.65%   68.65%           
=======================================
  Files          16       16           
  Lines        3292     3292           
=======================================
  Hits         2260     2260           
  Misses       1032     1032           
Impacted Files Coverage Δ
emmopy/emmocheck.py 53.20% <100.00%> (ø)
ontopy/manchester.py 92.22% <100.00%> (ø)

@francescalb francescalb merged commit 3d5b2f0 into master Jun 19, 2023
@francescalb francescalb deleted the flb/issue-627-emmocheck branch June 19, 2023 12:44
@francescalb francescalb mentioned this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyparsing has been updated
2 participants