Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected bug so that asking for entities in imported does not return all in world #655

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

francescalb
Copy link
Collaborator

@francescalb francescalb commented Sep 18, 2023

Description

Asking for entities in imported used ot return everything in world, this is obviously not correct if there are more ontologies in world or if we are asking for entities in one of the imported ontologies.

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #655 (fcd9e94) into master (047d9af) will increase coverage by 0.42%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #655      +/-   ##
==========================================
+ Coverage   68.85%   69.28%   +0.42%     
==========================================
  Files          16       16              
  Lines        3301     3324      +23     
==========================================
+ Hits         2273     2303      +30     
+ Misses       1028     1021       -7     
Files Changed Coverage Δ
ontopy/patch.py 59.86% <ø> (ø)
ontopy/ontology.py 77.86% <100.00%> (+1.68%) ⬆️

@francescalb francescalb self-assigned this Sep 18, 2023
@francescalb francescalb linked an issue Sep 18, 2023 that may be closed by this pull request
ontopy/ontology.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@jesper-friis jesper-friis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix. Added a comment

francescalb and others added 2 commits September 21, 2023 14:31
Co-authored-by: Jesper Friis <jesper-friis@users.noreply.github.com>
@francescalb francescalb merged commit b7f6005 into master Sep 22, 2023
12 checks passed
@francescalb francescalb deleted the classes_from_imported_ontologies_not_world branch September 22, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ontology(imported=True) returns all classes in world
2 participants