Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #657

Merged
merged 3 commits into from
Oct 9, 2023
Merged

Update README.md #657

merged 3 commits into from
Oct 9, 2023

Conversation

jesper-friis
Copy link
Collaborator

Description

Added the description from the OntoCommons D4.7 deliverably to the readme file.

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #657 (3c7ca7e) into master (b7f6005) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
+ Coverage   69.25%   69.28%   +0.03%     
==========================================
  Files          16       16              
  Lines        3324     3324              
==========================================
+ Hits         2302     2303       +1     
+ Misses       1022     1021       -1     

see 1 file with indirect coverage changes

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I have made a small suggestion for grammar. Note also that you need to update the index so that the tests pass before you can merge.

Co-authored-by: Francesca L. Bleken <48128015+francescalb@users.noreply.github.com>
@jesper-friis
Copy link
Collaborator Author

jesper-friis commented Oct 8, 2023

Nice, I have made a small suggestion for grammar. Note also that you need to update the index so that the tests pass before you can merge.

Not sure what's the problem with the index. pre-commit runs fine locally:

$ pre-commit run -a
check for broken symlinks................................................Passed
Check XML................................................................Passed
Check YAML...............................................................Passed
detect destroyed symlinks................................................Passed
fix end of files.........................................................Passed
Fix requirements*.txt....................................................Passed
trim trailing whitespace.................................................Passed
Blacken..................................................................Passed
bandit...................................................................Passed
Update API Reference in Documentation....................................Passed
Update Landing Page (index.md) for Documentation.........................Passed
pylint...................................................................Passed

Please feel free if you know how to fix it...

@jesper-friis jesper-friis merged commit eb53c4a into master Oct 9, 2023
12 checks passed
@jesper-friis jesper-friis deleted the update-readme branch October 9, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants