-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated emmocheck to new EMMO quantities and units #658
Conversation
Codecov Report
@@ Coverage Diff @@
## master #658 +/- ##
==========================================
+ Coverage 69.28% 69.49% +0.20%
==========================================
Files 16 16
Lines 3324 3350 +26
==========================================
+ Hits 2303 2328 +25
- Misses 1021 1022 +1
|
@jesper-friis There are several issues on updating emmocheck. Can you identify which one(s) this PR correponds to and link it(them)? Also, provide one more sentence about what this update is doing, it is not very intuitive. |
Updated description |
…ython into test_quantity_dimension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. It is actually being checked with specific commit version of emmo, so the miss in codecov is not correct.
Description
Updated emmocheck to new EMMO quantities and units to confirm to EMMO beta5.
Changes by this PR:
test_quantity_dimension()
totest_quantity_dimension_beta3
and skip it by default.test_physical_quantity_dimension_annotation()
by default (confirming to beta3).test_quantity_dimension()
that confirms to beta5.test_dimensional_unit()
that confirms to beta5.Addresses #627
Closes #347
Type of change
Checklist
This checklist can be used as a help for the reviewer.
Comments