Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated emmocheck to new EMMO quantities and units #658

Merged
merged 6 commits into from
Oct 9, 2023

Conversation

jesper-friis
Copy link
Collaborator

@jesper-friis jesper-friis commented Oct 1, 2023

Description

Updated emmocheck to new EMMO quantities and units to confirm to EMMO beta5.

Changes by this PR:

  • Rename old test_quantity_dimension() to test_quantity_dimension_beta3 and skip it by default.
  • Skip old test_physical_quantity_dimension_annotation() by default (confirming to beta3).
  • Implement new test_quantity_dimension() that confirms to beta5.
  • Implement new test_dimensional_unit() that confirms to beta5.

Addresses #627
Closes #347

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

@codecov
Copy link

codecov bot commented Oct 1, 2023

Codecov Report

Merging #658 (a60fc28) into master (eb53c4a) will increase coverage by 0.20%.
The diff coverage is 48.14%.

@@            Coverage Diff             @@
##           master     #658      +/-   ##
==========================================
+ Coverage   69.28%   69.49%   +0.20%     
==========================================
  Files          16       16              
  Lines        3324     3350      +26     
==========================================
+ Hits         2303     2328      +25     
- Misses       1021     1022       +1     
Files Coverage Δ
emmopy/emmocheck.py 53.71% <48.14%> (+0.50%) ⬆️

... and 2 files with indirect coverage changes

@francescalb
Copy link
Collaborator

@jesper-friis There are several issues on updating emmocheck. Can you identify which one(s) this PR correponds to and link it(them)? Also, provide one more sentence about what this update is doing, it is not very intuitive.

@jesper-friis
Copy link
Collaborator Author

@jesper-friis There are several issues on updating emmocheck. Can you identify which one(s) this PR correponds to and link it(them)? Also, provide one more sentence about what this update is doing, it is not very intuitive.

Updated description

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. It is actually being checked with specific commit version of emmo, so the miss in codecov is not correct.

@jesper-friis jesper-friis merged commit 8f971bd into master Oct 9, 2023
11 of 12 checks passed
@jesper-friis jesper-friis deleted the test_quantity_dimension branch October 9, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hasPhysicalDimension convention has changed in EMMO-1.0.0-beta3
2 participants