Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HermiT is default reasoner. #671

Merged
merged 7 commits into from
Nov 4, 2023
Merged

HermiT is default reasoner. #671

merged 7 commits into from
Nov 4, 2023

Conversation

francescalb
Copy link
Collaborator

@francescalb francescalb commented Nov 3, 2023

Ontoconvert used to accept only FaCT++ because
owlready2.reasoning._apply_reasoning_results() was broken. It added the inferred
rdfs:subClassOf relations as rdf:type relations.

Description

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

Ontoconvert used to accept only FaCT++ because
owlready2.reasoning._apply_reasoning_results() was broken.
It added the inferred
rdfs:subClassOf relations as rdf:type relations.
@francescalb francescalb linked an issue Nov 3, 2023 that may be closed by this pull request
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #671 (bb6900a) into master (acc7b5d) will increase coverage by 0.23%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #671      +/-   ##
==========================================
+ Coverage   69.85%   70.09%   +0.23%     
==========================================
  Files          16       16              
  Lines        3367     3367              
==========================================
+ Hits         2352     2360       +8     
+ Misses       1015     1007       -8     
Files Coverage Δ
ontopy/ontology.py 78.60% <ø> (+0.67%) ⬆️

... and 2 files with indirect coverage changes

Created dummy tests for all three reasoners.
Need to fill in with what we want to test for.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible improvement of this test:

Does testonto contain enough semantics for the reasoners to work with, such that they can add additional relations?
If not, one could consider to add an object property to testonto with a domain and range to give the reasoner something to work with.
If/when the reasoners add something, that should be tested for.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

tools/ontograph Outdated Show resolved Hide resolved
@francescalb francescalb changed the title HermiT is deafault reasoner. HermiT is default reasoner. Nov 3, 2023
@francescalb francescalb merged commit c50115b into master Nov 4, 2023
12 checks passed
@francescalb francescalb deleted the allow_hermit_ontoconvert branch November 4, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow using HermiT from ontoconvert
2 participants