Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added redirection checking tool #695

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Added redirection checking tool #695

merged 2 commits into from
Dec 21, 2023

Conversation

jesper-friis
Copy link
Collaborator

Description

Added new tool for testing redirections. Needed for testing the new w3id redirections.

This tool is placed in EMMOntoPy such that it is easy to pick up and use for EMMO and domain ontologies.

In the EMMO repo it will be used to test the redirections themselves, as specified in
https://github.com/perma-id/w3id.org/tree/master/emmo/expected_redirections.yaml (file to be pushed).

Domain ontologies can use this tool to check that they ahead to the repository layout conventions that are expected for the redirections to work.

Type of change

  • Bug fix.
  • New feature.
  • Documentation update.
  • Test update.

Checklist

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (41cafbb) 71.00% compared to head (b6594d1) 71.02%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #695      +/-   ##
==========================================
+ Coverage   71.00%   71.02%   +0.02%     
==========================================
  Files          16       16              
  Lines        3369     3369              
==========================================
+ Hits         2392     2393       +1     
+ Misses        977      976       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@jesper-friis jesper-friis merged commit 04f145f into master Dec 21, 2023
12 checks passed
@jesper-friis jesper-friis deleted the redirectioncheck branch December 21, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants